[Webkit-unassigned] [Bug 149100] Implement indirect calls in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149100

--- Comment #4 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Thanks for the review.

(In reply to comment #3)
> Comment on attachment 261077 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261077&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:610
> > +
> > +        const Vector<JSFunction*>& functions = m_module->functionPointerTables()[functionPointerTableIndex].functions;
> > +        move(TrustedImmPtr(functions.data()), GPRInfo::regT0);
> > +        load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT1);
> > +        m_tempStackTop--;
> 
> Can you guarantee that the vector will never resize (and thus never change
> its data pointer)?

WASM source is parsed in two passes. The first pass is for syntax checking and initializing some data. The second pass is for code generation. The vector only resizes in the first pass. It will never resize after that.

The vector only resizes when we load the WASM module and parse the function pointer tables. It will never resize after that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/05637967/attachment-0001.html>