[Webkit-unassigned] [Bug 149100] Implement indirect calls in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149100

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261077|review?                     |review+
              Flags|                            |

--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 261077
  --> https://bugs.webkit.org/attachment.cgi?id=261077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261077&action=review

r=me

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:610
> +
> +        const Vector<JSFunction*>& functions = m_module->functionPointerTables()[functionPointerTableIndex].functions;
> +        move(TrustedImmPtr(functions.data()), GPRInfo::regT0);
> +        load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT1);
> +        m_tempStackTop--;

Can you guarantee that the vector will never resize (and thus never change its data pointer)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/45a84e9b/attachment.html>