<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement indirect calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149100#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement indirect calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149100">bug 149100</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>Thanks for the review.
(In reply to <a href="show_bug.cgi?id=149100#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=261077&action=diff" name="attach_261077" title="Patch">attachment 261077</a> <a href="attachment.cgi?id=261077&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=261077&action=review">https://bugs.webkit.org/attachment.cgi?id=261077&action=review</a>
>
> r=me
>
> > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:610
> > +
> > + const Vector<JSFunction*>& functions = m_module->functionPointerTables()[functionPointerTableIndex].functions;
> > + move(TrustedImmPtr(functions.data()), GPRInfo::regT0);
> > + load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT1);
> > + m_tempStackTop--;
>
> Can you guarantee that the vector will never resize (and thus never change
> its data pointer)?</span >
WASM source is parsed in two passes. The first pass is for syntax checking and initializing some data. The second pass is for code generation. The vector only resizes in the first pass. It will never resize after that.
The vector only resizes when we load the WASM module and parse the function pointer tables. It will never resize after that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>