[Webkit-unassigned] [Bug 148882] Implement all the arithmetic and logical instructions in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148882

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260730|review?                     |review+
              Flags|                            |

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 260730
  --> https://bugs.webkit.org/attachment.cgi?id=260730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260730&action=review

r=me

> Source/JavaScriptCore/tests/stress/wasm-arithmetic.js:45
> +        return (6 * 7) | 0;

What's stopping the WASM compiler from just constant folding this operation and just returning a constant (thereby defeating this test)?  Why not pass the values into the test functions as arguments?  Unless there's a reason to not do so, please pass the args in to the test instead.  I'm fine with doing a follow up patch to update all the tests to do this.

> Source/JavaScriptCore/tests/stress/wasm-arithmetic.js:192
> +shouldBe(module.multiplyOverflow(), -2147483648);

What does it mean to multiplyOverflow?  Does WASM require that we overflow silently?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150908/d5f47153/attachment.html>