<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement all the arithmetic and logical instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148882">bug 148882</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260730 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement all the arithmetic and logical instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148882#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement all the arithmetic and logical instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148882">bug 148882</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260730&action=diff" name="attach_260730" title="Patch">attachment 260730</a> <a href="attachment.cgi?id=260730&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260730&action=review">https://bugs.webkit.org/attachment.cgi?id=260730&action=review</a>
r=me
<span class="quote">> Source/JavaScriptCore/tests/stress/wasm-arithmetic.js:45
> + return (6 * 7) | 0;</span >
What's stopping the WASM compiler from just constant folding this operation and just returning a constant (thereby defeating this test)? Why not pass the values into the test functions as arguments? Unless there's a reason to not do so, please pass the args in to the test instead. I'm fine with doing a follow up patch to update all the tests to do this.
<span class="quote">> Source/JavaScriptCore/tests/stress/wasm-arithmetic.js:192
> +shouldBe(module.multiplyOverflow(), -2147483648);</span >
What does it mean to multiplyOverflow? Does WASM require that we overflow silently?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>