[Webkit-unassigned] [Bug 149873] [Content Extensions] Content blocking rules are not consulted for pings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 14 17:33:07 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=149873
--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 263075
--> https://bugs.webkit.org/attachment.cgi?id=263075
Patch using Option (b)
View in context: https://bugs.webkit.org/attachment.cgi?id=263075&action=review
> Source/WebCore/loader/PingLoader.cpp:140
> + bool isSameSchemePort = frame.document()->securityOrigin()->isSameSchemeHostPort(SecurityOrigin::create(reportURL).ptr());
> + if (!isSameSchemePort)
> + request.setAllowCookies(false);
I think this would read better without the local variable.
Not new to this patch, but I donât understand why this doesnât have to null check document() or securityOrigin().
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/27b8298d/attachment.html>
More information about the webkit-unassigned
mailing list