[Webkit-unassigned] [Bug 149873] [Content Extensions] Content blocking rules are not consulted for pings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149873

--- Comment #24 from Roopesh Chander <roop+webkit at roopc.net> ---
Comment on attachment 263075
  --> https://bugs.webkit.org/attachment.cgi?id=263075
Patch using Option (b)

View in context: https://bugs.webkit.org/attachment.cgi?id=263075&action=review

>> Source/WebCore/loader/PingLoader.cpp:140
>> +    bool isSameSchemePort = frame.document()->securityOrigin()->isSameSchemeHostPort(SecurityOrigin::create(reportURL).ptr());
>> +    if (!isSameSchemePort)
>> +        request.setAllowCookies(false);
> 
> I think this would read better without the local variable.
> 
> Not new to this patch, but I don’t understand why this doesn’t have to null check document() or securityOrigin().

I'll resubmit with null checks and without the local variable.

There are quite a few other places in PingLoader.cpp that dereference document() and securityOrigin() without checking for null. Maybe they should be addressed in another bug? Can I file a new bug report and fix them there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/3e8fb89c/attachment.html>