<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings"
href="https://bugs.webkit.org/show_bug.cgi?id=149873#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings"
href="https://bugs.webkit.org/show_bug.cgi?id=149873">bug 149873</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=263075&action=diff" name="attach_263075" title="Patch using Option (b)">attachment 263075</a> <a href="attachment.cgi?id=263075&action=edit" title="Patch using Option (b)">[details]</a></span>
Patch using Option (b)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=263075&action=review">https://bugs.webkit.org/attachment.cgi?id=263075&action=review</a>
<span class="quote">> Source/WebCore/loader/PingLoader.cpp:140
> + bool isSameSchemePort = frame.document()->securityOrigin()->isSameSchemeHostPort(SecurityOrigin::create(reportURL).ptr());
> + if (!isSameSchemePort)
> + request.setAllowCookies(false);</span >
I think this would read better without the local variable.
Not new to this patch, but I don’t understand why this doesn’t have to null check document() or securityOrigin().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>