[Webkit-unassigned] [Bug 149835] Slider knobs should scale when rendering while zoomed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149835

--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 262514
  --> https://bugs.webkit.org/attachment.cgi?id=262514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262514&action=review

Thank you for the review! In regards to testing, there isn't currently a good way to test rendering of zoomed/scaled form controls. When getting other widgets to zoom a few weeks ago, I discussed ways to test this new behavior with Dan and Alexey, and we determined the only way to do this was to write pixel tests, but that since we don't run pixel tests the bots, writing new pixel tests wasn't that useful. We brainstormed a few ideas to address this issue and ended up filing https://bugs.webkit.org/show_bug.cgi?id=147193, but we'll need to have a broader conversation about ways to test rendering in WebKit beyond pixel tests.

>> Source/WebCore/platform/mac/ThemeMac.mm:688
>> +        std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::createCompatibleBuffer(rect.size() + 2 * FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth), deviceScaleFactor, ColorSpaceSRGB, context, false);
> 
> I suggest we use auto here instead of explicitly listing the type.

Got it -- changed.

>> Source/WebCore/platform/mac/ThemeMac.mm:697
>> +        needsRepaint = drawCellOrFocusRingIntoRectWithView(cell, NSRect(rect), view, drawButtonCell, drawFocusRing);
> 
> Why the syntax NSRect(rect) here? Won’t the code compile without the explicit conversation?

Unfortunately, without the explicit conversion, 32-bit builds won't compile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151006/c3572762/attachment.html>