<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Slider knobs should scale when rendering while zoomed"
href="https://bugs.webkit.org/show_bug.cgi?id=149835#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Slider knobs should scale when rendering while zoomed"
href="https://bugs.webkit.org/show_bug.cgi?id=149835">bug 149835</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262514&action=diff" name="attach_262514" title="Patch">attachment 262514</a> <a href="attachment.cgi?id=262514&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262514&action=review">https://bugs.webkit.org/attachment.cgi?id=262514&action=review</a>
Thank you for the review! In regards to testing, there isn't currently a good way to test rendering of zoomed/scaled form controls. When getting other widgets to zoom a few weeks ago, I discussed ways to test this new behavior with Dan and Alexey, and we determined the only way to do this was to write pixel tests, but that since we don't run pixel tests the bots, writing new pixel tests wasn't that useful. We brainstormed a few ideas to address this issue and ended up filing <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement an internal API to paint DOM elements onto a canvas for testing"
href="show_bug.cgi?id=147193">https://bugs.webkit.org/show_bug.cgi?id=147193</a>, but we'll need to have a broader conversation about ways to test rendering in WebKit beyond pixel tests.
<span class="quote">>> Source/WebCore/platform/mac/ThemeMac.mm:688
>> + std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::createCompatibleBuffer(rect.size() + 2 * FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth), deviceScaleFactor, ColorSpaceSRGB, context, false);
>
> I suggest we use auto here instead of explicitly listing the type.</span >
Got it -- changed.
<span class="quote">>> Source/WebCore/platform/mac/ThemeMac.mm:697
>> + needsRepaint = drawCellOrFocusRingIntoRectWithView(cell, NSRect(rect), view, drawButtonCell, drawFocusRing);
>
> Why the syntax NSRect(rect) here? Won’t the code compile without the explicit conversation?</span >
Unfortunately, without the explicit conversion, 32-bit builds won't compile.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>