[Webkit-unassigned] [Bug 149835] Slider knobs should scale when rendering while zoomed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149835

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262514|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 262514
  --> https://bugs.webkit.org/attachment.cgi?id=262514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262514&action=review

Is there a good way to make a regression test for this? I don’t like making this fix without a test.

> Source/WebCore/platform/mac/ThemeMac.mm:688
> +        std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::createCompatibleBuffer(rect.size() + 2 * FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth), deviceScaleFactor, ColorSpaceSRGB, context, false);

I suggest we use auto here instead of explicitly listing the type.

> Source/WebCore/platform/mac/ThemeMac.mm:697
> +        needsRepaint = drawCellOrFocusRingIntoRectWithView(cell, NSRect(rect), view, drawButtonCell, drawFocusRing);

Why the syntax NSRect(rect) here? Won’t the code compile without the explicit conversation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151006/fd21cd12/attachment.html>