[Webkit-unassigned] [Bug 151256] [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151256

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #10)
> Comment on attachment 265573 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265573&action=review
> 
> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:296
> > +    m_pipeline = gst_pipeline_new(nullptr);
> 
> Should the returned pointer be adopted?

No, it's a floating ref we should consume.

> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:312
> > +        gst_message_unref(message);
> 
> This was leaking before, was it not?

No, when using the message signal, gst unrefs the message, when using the sync handler, you must unref it when returning DROP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151116/665df20d/attachment.html>