<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256">bug 151256</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151256#c10">comment #10</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=265573&action=diff" name="attach_265573" title="Updated patch">attachment 265573</a> <a href="attachment.cgi?id=265573&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=265573&action=review">https://bugs.webkit.org/attachment.cgi?id=265573&action=review</a>
>
> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:296
> > + m_pipeline = gst_pipeline_new(nullptr);
>
> Should the returned pointer be adopted?</span >
No, it's a floating ref we should consume.
<span class="quote">> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:312
> > + gst_message_unref(message);
>
> This was leaking before, was it not?</span >
No, when using the message signal, gst unrefs the message, when using the sync handler, you must unref it when returning DROP.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>