[Webkit-unassigned] [Bug 151256] [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151256

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265573|review?                     |review+
              Flags|                            |

--- Comment #10 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 265573
  --> https://bugs.webkit.org/attachment.cgi?id=265573
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265573&action=review

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:296
> +    m_pipeline = gst_pipeline_new(nullptr);

Should the returned pointer be adopted?

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:312
> +        gst_message_unref(message);

This was leaking before, was it not?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151116/5aed70aa/attachment.html>