[Webkit-unassigned] [Bug 150807] [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150807

--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 264600
  --> https://bugs.webkit.org/attachment.cgi?id=264600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264600&action=review

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:90
> +        m_timer.stop();
> +        LockHolder locker(m_sampleMutex);

Any reason behind this ordering? The m_timer is being operated on under a lock in requestRender().

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:145
> +        if (currentCaps)
> +            gst_caps_unref(currentCaps);

Why is this being dereferenced in the constructor?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151103/9b9c107c/attachment.html>