[Webkit-unassigned] [Bug 150807] [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150807

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 264600 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264600&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Since we always wait until the smaple is actually rendered we
> 
> sample is misspelled here

Oops. I'll fix it.

> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:78
> > +        // Use a higher priority than WebCore timers (G_PRIORITY_HIGH_IDLE + 20).
> > +        m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 19);
> 
> This code is compiled for EFL, too. But this code is glib-specific. Is that
> OK for that port? Compile failed.

Yes, I forgot to add platform ifdef there.

> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:140
> > +struct _WebKitVideoSinkPrivate {
> 
> This peculiar use of a leading underscore followed by a capital letter
> trespasses on namespace that is reserved for compiler implementation, I
> believe.

This is the normal way to declare the structs in GObject. They are forward declared as typedef struct _Foo Foo; and then struct _Foo { }

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151103/263ed565/attachment-0001.html>