[Webkit-unassigned] [Bug 150807] [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150807

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 264600 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264600&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:90
> > +        m_timer.stop();
> > +        LockHolder locker(m_sampleMutex);
> 
> Any reason behind this ordering? The m_timer is being operated on under a
> lock in requestRender().

Tried to follow what previous code did. We don't need the lock to protect the timer I think

> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:145
> > +        if (currentCaps)
> > +            gst_caps_unref(currentCaps);
> 
> Why is this being dereferenced in the constructor?

Oh, good catch, that was supposed to be in the destructor :-P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151103/07ae8b55/attachment-0001.html>