[Webkit-unassigned] [Bug 150807] [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 2 22:30:23 PST 2015


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 264600
  --> https://bugs.webkit.org/attachment.cgi?id=264600

View in context: https://bugs.webkit.org/attachment.cgi?id=264600&action=review

> Source/WebCore/ChangeLog:8
> +        Since we always wait until the smaple is actually rendered we

sample is misspelled here

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:78
> +        // Use a higher priority than WebCore timers (G_PRIORITY_HIGH_IDLE + 20).
> +        m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 19);

This code is compiled for EFL, too. But this code is glib-specific. Is that OK for that port? Compile failed.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:140
> +struct _WebKitVideoSinkPrivate {

This peculiar use of a leading underscore followed by a capital letter trespasses on namespace that is reserved for compiler implementation, I believe.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151103/7dd7f875/attachment.html>

More information about the webkit-unassigned mailing list