[Webkit-unassigned] [Bug 144770] Media Controls stop update after hovering for a few seconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144770

Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253390|review?                     |review+
              Flags|                            |

--- Comment #27 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 253390
  --> https://bugs.webkit.org/attachment.cgi?id=253390
patchh

View in context: https://bugs.webkit.org/attachment.cgi?id=253390&action=review

r=me, with nits.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:210
> +    controlsAreHidden: function()
> +    {
> +        // Controls are only ever actually hidden when they are removed from the tree
> +        return !this.controls.panelContainer.parentElement;
> +    },
> +

It's unfortunate that we have to duplicate this work in the iOS controls. Can we refactor out this.controls.panelContainer into this.controls.panel, and remove this method?

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:397
> +    handlePanelTransitionEnd: function(event)
> +    {
> +        var opacity = window.getComputedStyle(this.controls.panel).opacity;
> +        if (!parseInt(opacity) && !this.controlsAlwaysVisible()) {
> +            this.base.removeChild(this.controls.inlinePlaybackPlaceholder);
> +            this.base.removeChild(this.controls.panelContainer);
> +        }
> +    },
> +

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:562
> +    showControls: function()
> +    {
> +        this.updateShouldListenForPlaybackTargetAvailabilityEvent();
> +        if (this.showInlinePlaybackPlaceholderOnly())
> +            return;
> +        
> +        this.updateForShowingControls();
> +        if (this.shouldHaveControls()) {
> +            this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
> +            this.base.appendChild(this.controls.panelContainer);
> +        }
> +    },
> +

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/71c99d11/attachment.html>