<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770">bug 144770</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253390 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770#c27">Comment # 27</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770">bug 144770</a>
from <span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253390&action=diff" name="attach_253390" title="patchh">attachment 253390</a> <a href="attachment.cgi?id=253390&action=edit" title="patchh">[details]</a></span>
patchh
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253390&action=review">https://bugs.webkit.org/attachment.cgi?id=253390&action=review</a>
r=me, with nits.
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:210
> + controlsAreHidden: function()
> + {
> + // Controls are only ever actually hidden when they are removed from the tree
> + return !this.controls.panelContainer.parentElement;
> + },
> +</span >
It's unfortunate that we have to duplicate this work in the iOS controls. Can we refactor out this.controls.panelContainer into this.controls.panel, and remove this method?
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:397
> + handlePanelTransitionEnd: function(event)
> + {
> + var opacity = window.getComputedStyle(this.controls.panel).opacity;
> + if (!parseInt(opacity) && !this.controlsAlwaysVisible()) {
> + this.base.removeChild(this.controls.inlinePlaybackPlaceholder);
> + this.base.removeChild(this.controls.panelContainer);
> + }
> + },
> +</span >
Ditto.
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:562
> + showControls: function()
> + {
> + this.updateShouldListenForPlaybackTargetAvailabilityEvent();
> + if (this.showInlinePlaybackPlaceholderOnly())
> + return;
> +
> + this.updateForShowingControls();
> + if (this.shouldHaveControls()) {
> + this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
> + this.base.appendChild(this.controls.panelContainer);
> + }
> + },
> +</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>