[Webkit-unassigned] [Bug 144770] Media Controls stop update after hovering for a few seconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144770

--- Comment #26 from Roger Fong <roger_fong at apple.com> ---
(In reply to comment #25)
> Comment on attachment 253390 [details]
> patchh
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253390&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        It should only happen when the mouse leaves the video entirely.
> 
> What about fullscreen video?

This is also true of fullscreen video.
If your mouse leaves the fullscreen video (I guess this would happen with multiple monitors) the controls should disappear. If you only have one screen then they will always appear as soon as you move the mouse anywhere on the screen and can only disappear as a result of no mouse movement for a certain amount of time.

> 
> > Source/WebCore/ChangeLog:17
> > +        remove controls entirely from the tree.
> 
> Why?

This is the strategy that Simon, Jer and I finally settled on for avoiding unnecessary paints and style recalcs, simply to remove the controls entirely when they are hidden and re-add them back in when they are shown. This way we can call updateTime and progress as much as we want while the controls are hidden with none of those performance penalties.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/920c65c6/attachment.html>