[Webkit-unassigned] [Bug 144738] REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144738

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #12)
> Comment on attachment 253126 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253126&action=review

Thanks!

> > But the downloads implementation in mac is not cross-platform at all, no?
> 
> What I'm talking about is that abstractions should abstract out platform
> differences. We have cross-platform abstractions for ResourceHandle and
> ResourceHandleClient. Code that uses those should expect identical behavior
> on all platforms - if it's correct to set the client to null on Mac, it
> should be the correct thing to do everywhere.

Ok, got it.

> > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1042
> > +    return WTF::move(newHandle);
> 
> Is WTF::move needed? I thought that C++11 must move automatically in this
> case.

I think we can just return the RefPtr, yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150515/7722383f/attachment.html>