[Webkit-unassigned] [Bug 144738] REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144738

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253126|review?                     |review+
              Flags|                            |

--- Comment #12 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 253126
  --> https://bugs.webkit.org/attachment.cgi?id=253126
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253126&action=review

> But the downloads implementation in mac is not cross-platform at all, no?

What I'm talking about is that abstractions should abstract out platform differences. We have cross-platform abstractions for ResourceHandle and ResourceHandleClient. Code that uses those should expect identical behavior on all platforms - if it's correct to set the client to null on Mac, it should be the correct thing to do everywhere.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1042
> +    return WTF::move(newHandle);

Is WTF::move needed? I thought that C++11 must move automatically in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150514/0b6e186e/attachment.html>