<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738">bug 144738</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144738#c12">comment #12</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253126&action=diff" name="attach_253126" title="Updated patch">attachment 253126</a> <a href="attachment.cgi?id=253126&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253126&action=review">https://bugs.webkit.org/attachment.cgi?id=253126&action=review</a></span >
Thanks!
<span class="quote">> > But the downloads implementation in mac is not cross-platform at all, no?
>
> What I'm talking about is that abstractions should abstract out platform
> differences. We have cross-platform abstractions for ResourceHandle and
> ResourceHandleClient. Code that uses those should expect identical behavior
> on all platforms - if it's correct to set the client to null on Mac, it
> should be the correct thing to do everywhere.</span >
Ok, got it.
<span class="quote">> > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1042
> > + return WTF::move(newHandle);
>
> Is WTF::move needed? I thought that C++11 must move automatically in this
> case.</span >
I think we can just return the RefPtr, yes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>