<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738">bug 144738</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253126 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738">bug 144738</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253126&action=diff" name="attach_253126" title="Updated patch">attachment 253126</a> <a href="attachment.cgi?id=253126&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253126&action=review">https://bugs.webkit.org/attachment.cgi?id=253126&action=review</a>
<span class="quote">> But the downloads implementation in mac is not cross-platform at all, no?</span >
What I'm talking about is that abstractions should abstract out platform differences. We have cross-platform abstractions for ResourceHandle and ResourceHandleClient. Code that uses those should expect identical behavior on all platforms - if it's correct to set the client to null on Mac, it should be the correct thing to do everywhere.
<span class="quote">> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1042
> + return WTF::move(newHandle);</span >
Is WTF::move needed? I thought that C++11 must move automatically in this case.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>