[Webkit-unassigned] [Bug 144909] [EGL][X11] XPixmap created in GLContextEGL::createPixmapContext() is leaked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144909

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 252959 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252959&action=review
> 
> > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:66
> > +    static EGLint attributeList[] = {
> 
> This is a bit unusual, since in the project we don't normally modify static
> data (apart from initialization steps).

Ok, it's also a bit unrelated to this patch anyway.

> > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:220
> > +GLContextEGL::GLContextEGL(EGLContext context, EGLSurface surface, XUniquePixmap&& pixmap)
> 
> This constructor should be guarded with PLATFORM(X11).

Right!

> > Source/WebCore/platform/graphics/egl/GLContextEGL.h:42
> > +    GLContextEGL(EGLContext, EGLSurface, XUniquePixmap&&);
> 
> Ditto for the PLATFORM(X11) guards.

Sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150513/b9da96f2/attachment.html>