[Webkit-unassigned] [Bug 144909] [EGL][X11] XPixmap created in GLContextEGL::createPixmapContext() is leaked
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 12 12:50:52 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=144909
--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 252959
--> https://bugs.webkit.org/attachment.cgi?id=252959
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=252959&action=review
> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:66
> + static EGLint attributeList[] = {
This is a bit unusual, since in the project we don't normally modify static data (apart from initialization steps).
> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:220
> +GLContextEGL::GLContextEGL(EGLContext context, EGLSurface surface, XUniquePixmap&& pixmap)
This constructor should be guarded with PLATFORM(X11).
> Source/WebCore/platform/graphics/egl/GLContextEGL.h:42
> + GLContextEGL(EGLContext, EGLSurface, XUniquePixmap&&);
Ditto for the PLATFORM(X11) guards.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150512/360c55e8/attachment-0001.html>
More information about the webkit-unassigned
mailing list