<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL][X11] XPixmap created in GLContextEGL::createPixmapContext() is leaked"
href="https://bugs.webkit.org/show_bug.cgi?id=144909#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL][X11] XPixmap created in GLContextEGL::createPixmapContext() is leaked"
href="https://bugs.webkit.org/show_bug.cgi?id=144909">bug 144909</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144909#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252959&action=diff" name="attach_252959" title="Patch">attachment 252959</a> <a href="attachment.cgi?id=252959&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252959&action=review">https://bugs.webkit.org/attachment.cgi?id=252959&action=review</a>
>
> > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:66
> > + static EGLint attributeList[] = {
>
> This is a bit unusual, since in the project we don't normally modify static
> data (apart from initialization steps).</span >
Ok, it's also a bit unrelated to this patch anyway.
<span class="quote">> > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:220
> > +GLContextEGL::GLContextEGL(EGLContext context, EGLSurface surface, XUniquePixmap&& pixmap)
>
> This constructor should be guarded with PLATFORM(X11).</span >
Right!
<span class="quote">> > Source/WebCore/platform/graphics/egl/GLContextEGL.h:42
> > + GLContextEGL(EGLContext, EGLSurface, XUniquePixmap&&);
>
> Ditto for the PLATFORM(X11) guards.</span >
Sure.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>