[Webkit-unassigned] [Bug 144748] [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144748

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 252594 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252594&action=review
> 
> That's a r=me. Another WebKitGtk reviewer must approve the new API though

Thanks!, you can safely r+, cq- I won't land it until I get the second approval.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> > +    if (currentValue == allowed)
> 
> currentValue is not really needed. I think using the function call directly
> is explicit enough.

Yes, we have that pattern in the whole file, I don't remember if there was a reason, or we just copy-pasted every time :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150508/2a295330/attachment.html>