<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API"
href="https://bugs.webkit.org/show_bug.cgi?id=144748#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API"
href="https://bugs.webkit.org/show_bug.cgi?id=144748">bug 144748</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144748#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252594&action=diff" name="attach_252594" title="Patch">attachment 252594</a> <a href="attachment.cgi?id=252594&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252594&action=review">https://bugs.webkit.org/attachment.cgi?id=252594&action=review</a>
>
> That's a r=me. Another WebKitGtk reviewer must approve the new API though</span >
Thanks!, you can safely r+, cq- I won't land it until I get the second approval.
<span class="quote">> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> > + if (currentValue == allowed)
>
> currentValue is not really needed. I think using the function call directly
> is explicit enough.</span >
Yes, we have that pattern in the whole file, I don't remember if there was a reason, or we just copy-pasted every time :-)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>