[Webkit-unassigned] [Bug 144748] [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 23:45:01 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144748

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 252594
  --> https://bugs.webkit.org/attachment.cgi?id=252594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252594&action=review

That's a r=me. Another WebKitGtk reviewer must approve the new API though

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> +    if (currentValue == allowed)

currentValue is not really needed. I think using the function call directly is explicit enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150508/fe50ee0b/attachment.html>


More information about the webkit-unassigned mailing list