[Webkit-unassigned] [Bug 144663] New force-related DOM events should fire in WK1 views

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144663

--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 252527
  --> https://bugs.webkit.org/attachment.cgi?id=252527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252527&action=review

> Source/WebCore/page/mac/EventHandlerMac.mm:86
> +    static NeverDestroyed<RetainPtr<NSEvent>> event;

Is it really right for this to be stored between views? That seems weird.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:428
> +        if ([event type] == NSEventTypePressure) {

You check this three times in this function. Maybe put it in a local?

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:439
> +    UNUSED_PARAM(lastPressureEvent);

Indentation is wrong I think.

> Source/WebKit/mac/WebView/WebHTMLView.mm:-3844
> -    [[[self _webView] _immediateActionController] webView:[self _webView] willHandleMouseDown:event];

Whaaaaaa?

> Source/WebKit/mac/WebView/WebViewData.h:178
> +    NSEvent *pressureEvent;

Maybe lastPressureEvent?

Could you not keep this in EventHandler instead and avoid keeping it here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/403784b0/attachment-0001.html>