<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663">bug 144663</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252527&action=diff" name="attach_252527" title="Patch">attachment 252527</a> <a href="attachment.cgi?id=252527&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252527&action=review">https://bugs.webkit.org/attachment.cgi?id=252527&action=review</a>
<span class="quote">> Source/WebCore/page/mac/EventHandlerMac.mm:86
> + static NeverDestroyed<RetainPtr<NSEvent>> event;</span >
Is it really right for this to be stored between views? That seems weird.
<span class="quote">> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:428
> + if ([event type] == NSEventTypePressure) {</span >
You check this three times in this function. Maybe put it in a local?
<span class="quote">> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:439
> + UNUSED_PARAM(lastPressureEvent);</span >
Indentation is wrong I think.
<span class="quote">> Source/WebKit/mac/WebView/WebHTMLView.mm:-3844
> - [[[self _webView] _immediateActionController] webView:[self _webView] willHandleMouseDown:event];</span >
Whaaaaaa?
<span class="quote">> Source/WebKit/mac/WebView/WebViewData.h:178
> + NSEvent *pressureEvent;</span >
Maybe lastPressureEvent?
Could you not keep this in EventHandler instead and avoid keeping it here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>