[Webkit-unassigned] [Bug 144663] New force-related DOM events should fire in WK1 views

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144663

--- Comment #6 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #5)
> Comment on attachment 252527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252527&action=review
> 
> > Source/WebCore/page/mac/EventHandlerMac.mm:86
> > +    static NeverDestroyed<RetainPtr<NSEvent>> event;
> 
> Is it really right for this to be stored between views? That seems weird.
> 

Hmm, maybe not. I was copying what's done for currentNSEventSlot(). I think it makes as much sense in this new case as it did in the old, but I'm a little unsure here.

> > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:428
> > +        if ([event type] == NSEventTypePressure) {
> 
> You check this three times in this function. Maybe put it in a local?
> 

Sure, I can fix this up.

> > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:439
> > +    UNUSED_PARAM(lastPressureEvent);
> 
> Indentation is wrong I think.
> 

Will look.

> > Source/WebKit/mac/WebView/WebHTMLView.mm:-3844
> > -    [[[self _webView] _immediateActionController] webView:[self _webView] willHandleMouseDown:event];
> 
> Whaaaaaa?
> 

This is because mouseDown used to come after the immediate action! Remember? We used to have shenanigans like this in WK2 as well, and we were able to remove them when we switched to delaysPrimaryMouseEvents:NO. This code was there purely because we were getting mouse down at a weird time.

> > Source/WebKit/mac/WebView/WebViewData.h:178
> > +    NSEvent *pressureEvent;
> 
> Maybe lastPressureEvent?
> 

Sure.

> Could you not keep this in EventHandler instead and avoid keeping it here?

Hmmmmmmm. I'll have to think this over. This is a closer mirror to what we do in WK2. If we moved it to EventHandler, we would have WK1 only member variables there, which we actually manage to avoid at this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/8335879d/attachment-0001.html>