[Webkit-unassigned] [Bug 144685] [EGL] Move EGLDisplay handling to PlatformDisplay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144685

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252470|review?                     |review+
              Flags|                            |

--- Comment #3 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 252470
  --> https://bugs.webkit.org/attachment.cgi?id=252470
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=252470&action=review

> Source/WebCore/platform/graphics/PlatformDisplay.cpp:139
> +#if USE(OPENGL_ES_2)
> +    static const EGLenum eglAPIVersion = EGL_OPENGL_ES_API;
> +#else
> +    static const EGLenum eglAPIVersion = EGL_OPENGL_API;
> +#endif
> +    if (eglBindAPI(eglAPIVersion) == EGL_FALSE) {
> +        LOG_ERROR("Failed to set EGL API(%d).", eglGetError());
> +        terminateEGLDisplay();
> +        return;
> +    }

This needs to be called once per program, not once per display. Perhaps you could surround this with std::once.

> Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:153
> -    m_glxPixmap = glXCreateGLXPixmap(m_sharedDisplay, visualInfo.get(), m_pixmap);
> +    m_glxPixmap = glXCreateGLXPixmap(X11Helper::nativeDisplay(), visualInfo.get(), m_pixmap);

This is GLX-related, so perhaps you could update the bug title and ChangeLog slightly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150506/1bbd5430/attachment.html>