<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay"
href="https://bugs.webkit.org/show_bug.cgi?id=144685">bug 144685</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252470 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay"
href="https://bugs.webkit.org/show_bug.cgi?id=144685#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay"
href="https://bugs.webkit.org/show_bug.cgi?id=144685">bug 144685</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252470&action=diff" name="attach_252470" title="Try to fix EFL build">attachment 252470</a> <a href="attachment.cgi?id=252470&action=edit" title="Try to fix EFL build">[details]</a></span>
Try to fix EFL build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252470&action=review">https://bugs.webkit.org/attachment.cgi?id=252470&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/PlatformDisplay.cpp:139
> +#if USE(OPENGL_ES_2)
> + static const EGLenum eglAPIVersion = EGL_OPENGL_ES_API;
> +#else
> + static const EGLenum eglAPIVersion = EGL_OPENGL_API;
> +#endif
> + if (eglBindAPI(eglAPIVersion) == EGL_FALSE) {
> + LOG_ERROR("Failed to set EGL API(%d).", eglGetError());
> + terminateEGLDisplay();
> + return;
> + }</span >
This needs to be called once per program, not once per display. Perhaps you could surround this with std::once.
<span class="quote">> Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:153
> - m_glxPixmap = glXCreateGLXPixmap(m_sharedDisplay, visualInfo.get(), m_pixmap);
> + m_glxPixmap = glXCreateGLXPixmap(X11Helper::nativeDisplay(), visualInfo.get(), m_pixmap);</span >
This is GLX-related, so perhaps you could update the bug title and ChangeLog slightly?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>