[Webkit-unassigned] [Bug 134488] Async loading of image resources

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 12:27:29 PDT 2015


--- Comment #59 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 249755
  --> https://bugs.webkit.org/attachment.cgi?id=249755

View in context: https://bugs.webkit.org/attachment.cgi?id=249755&action=review

> Source/WebCore/loader/ImageLoader.cpp:72
> +    static std::unique_ptr<ImageLoaderTask> create(WeakPtr<ImageLoader> loader, bool shouldBypassMainWorldContentSecurityPolicy)

nit: I think we decided to get rid of these factory methods for std::unique_ptr and use std::make_unique<>() at call sites. Note that it requires making the constructor public though.

> Source/WebCore/loader/ImageLoader.h:80
> +    bool pendingTask() const { return m_pendingTask; }

for booleans, we prefer names that start with "is" or "has", in this case, hasPendingTask() / m_hasPendingTask would be nicer.

> Source/WebCore/loader/ImageLoader.h:109
> +    bool shouldLoadImmediately(const AtomicString&) const;

I don't think we should omit the argument name here as it is not obvious what it is.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150331/599e266b/attachment-0002.html>

More information about the webkit-unassigned mailing list