[Webkit-unassigned] [Bug 134488] Async loading of image resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134488

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249755|review?                     |review+
              Flags|                            |

--- Comment #58 from Dean Jackson <dino at apple.com> ---
Comment on attachment 249755
  --> https://bugs.webkit.org/attachment.cgi?id=249755
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249755&action=review

> Source/WebCore/html/HTMLImageLoader.cpp:81
> +    if (!cachedImage)
> +        return;
> +    ASSERT(cachedImage);

I really hope that ASSERT can never fire :)

> Source/WebCore/loader/ImageLoader.cpp:200
> +    // set url value only if srcURI is not empty. Otherwise, url will be the URL for the document itself.

Nit: "Set" not "set"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150331/72436787/attachment-0002.html>