[Webkit-unassigned] [Bug 146313] WebRTC: Update the MediaStream API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146313

--- Comment #3 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #2)
> Comment on attachment 255723 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255723&action=review
> 
> > Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:90
> > +    Vector<RefPtr<MediaStreamTrackPrivate>> tracks;
> > +    tracks.reserveCapacity(m_trackSet.size());
> >  
> > -    unsigned providedTracksSize = audioPrivateTracks.size() + videoPrivateTracks.size();
> > -    unsigned tracksSize = m_audioPrivateTracks.size() + m_videoPrivateTracks.size();
> > +    for (auto& track : m_trackSet.values())
> > +        tracks.append(track);
> >  
> > -    if (providedTracksSize > 0 && tracksSize > 0)
> > -        m_isActive = true;
> > +    return tracks;
> 
> Nit: you could use copyValuesToVector here.

Fixed.

> > Source/WebCore/platform/mediastream/MediaStreamPrivate.h:65
> > +    enum NotifyClientOption { NotifyClient, DontNotifyClient };
> 
> This should be "enum class".

Fixed (fixed other enum as well)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150629/84f24f8e/attachment-0001.html>