<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update the MediaStream API"
href="https://bugs.webkit.org/show_bug.cgi?id=146313#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update the MediaStream API"
href="https://bugs.webkit.org/show_bug.cgi?id=146313">bug 146313</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146313#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255723&action=diff" name="attach_255723" title="Proposed patch">attachment 255723</a> <a href="attachment.cgi?id=255723&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255723&action=review">https://bugs.webkit.org/attachment.cgi?id=255723&action=review</a>
>
> > Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:90
> > + Vector<RefPtr<MediaStreamTrackPrivate>> tracks;
> > + tracks.reserveCapacity(m_trackSet.size());
> >
> > - unsigned providedTracksSize = audioPrivateTracks.size() + videoPrivateTracks.size();
> > - unsigned tracksSize = m_audioPrivateTracks.size() + m_videoPrivateTracks.size();
> > + for (auto& track : m_trackSet.values())
> > + tracks.append(track);
> >
> > - if (providedTracksSize > 0 && tracksSize > 0)
> > - m_isActive = true;
> > + return tracks;
>
> Nit: you could use copyValuesToVector here.</span >
Fixed.
<span class="quote">> > Source/WebCore/platform/mediastream/MediaStreamPrivate.h:65
> > + enum NotifyClientOption { NotifyClient, DontNotifyClient };
>
> This should be "enum class".</span >
Fixed (fixed other enum as well)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>