[Webkit-unassigned] [Bug 146313] WebRTC: Update the MediaStream API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146313

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255723|review?                     |review+
              Flags|                            |

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 255723
  --> https://bugs.webkit.org/attachment.cgi?id=255723
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255723&action=review

> Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:90
> +    Vector<RefPtr<MediaStreamTrackPrivate>> tracks;
> +    tracks.reserveCapacity(m_trackSet.size());
>  
> -    unsigned providedTracksSize = audioPrivateTracks.size() + videoPrivateTracks.size();
> -    unsigned tracksSize = m_audioPrivateTracks.size() + m_videoPrivateTracks.size();
> +    for (auto& track : m_trackSet.values())
> +        tracks.append(track);
>  
> -    if (providedTracksSize > 0 && tracksSize > 0)
> -        m_isActive = true;
> +    return tracks;

Nit: you could use copyValuesToVector here.

> Source/WebCore/platform/mediastream/MediaStreamPrivate.h:65
> +    enum NotifyClientOption { NotifyClient, DontNotifyClient };

This should be "enum class".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150628/6d8529c2/attachment.html>