<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update the MediaStream API"
href="https://bugs.webkit.org/show_bug.cgi?id=146313">bug 146313</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255723 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update the MediaStream API"
href="https://bugs.webkit.org/show_bug.cgi?id=146313#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Update the MediaStream API"
href="https://bugs.webkit.org/show_bug.cgi?id=146313">bug 146313</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255723&action=diff" name="attach_255723" title="Proposed patch">attachment 255723</a> <a href="attachment.cgi?id=255723&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255723&action=review">https://bugs.webkit.org/attachment.cgi?id=255723&action=review</a>
<span class="quote">> Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:90
> + Vector<RefPtr<MediaStreamTrackPrivate>> tracks;
> + tracks.reserveCapacity(m_trackSet.size());
>
> - unsigned providedTracksSize = audioPrivateTracks.size() + videoPrivateTracks.size();
> - unsigned tracksSize = m_audioPrivateTracks.size() + m_videoPrivateTracks.size();
> + for (auto& track : m_trackSet.values())
> + tracks.append(track);
>
> - if (providedTracksSize > 0 && tracksSize > 0)
> - m_isActive = true;
> + return tracks;</span >
Nit: you could use copyValuesToVector here.
<span class="quote">> Source/WebCore/platform/mediastream/MediaStreamPrivate.h:65
> + enum NotifyClientOption { NotifyClient, DontNotifyClient };</span >
This should be "enum class".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>