[Webkit-unassigned] [Bug 146355] Add support for 'Default' media session types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 27 15:31:16 PDT 2015


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #255676|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 255676
  --> https://bugs.webkit.org/attachment.cgi?id=255676

View in context: https://bugs.webkit.org/attachment.cgi?id=255676&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:62
> +    , m_kind(MediaSession::Kind::Default)

Here in the MediaSession class, the name of this type is Kind, not MediaSession::Kind, so can leave off the MediaSession part.

Seems that m_kind could default to this in the header, then we could omit it in this constructor. Syntax we would normally use in the class definition is:

    Kind m_kind { Kind::Default };

> Source/WebCore/Modules/mediasession/MediaSession.h:53
> +    MediaSession(Document&);

Probably should be:

    explicit MediaSession(Document&);

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150627/bf35ea99/attachment.html>

More information about the webkit-unassigned mailing list