[Webkit-unassigned] [Bug 146355] Add support for 'Default' media session types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146355

--- Comment #4 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #3)
> Comment on attachment 255676 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255676&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:62
> > +    , m_kind(MediaSession::Kind::Default)
> 
> Here in the MediaSession class, the name of this type is Kind, not
> MediaSession::Kind, so can leave off the MediaSession part.
> 
> Seems that m_kind could default to this in the header, then we could omit it
> in this constructor. Syntax we would normally use in the class definition is:
> 
>     Kind m_kind { Kind::Default };

That's simpler. Changed.

> 
> > Source/WebCore/Modules/mediasession/MediaSession.h:53
> > +    MediaSession(Document&);
> 
> Probably should be:
> 
>     explicit MediaSession(Document&);

Yup, looks like we use `explicit` heavily throughout WebKit to avoid implicit conversions with single-argument constructors.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150629/8ad5d4dd/attachment.html>