<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for 'Default' media session types"
href="https://bugs.webkit.org/show_bug.cgi?id=146355">bug 146355</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255676 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for 'Default' media session types"
href="https://bugs.webkit.org/show_bug.cgi?id=146355#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for 'Default' media session types"
href="https://bugs.webkit.org/show_bug.cgi?id=146355">bug 146355</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255676&action=diff" name="attach_255676" title="Patch">attachment 255676</a> <a href="attachment.cgi?id=255676&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255676&action=review">https://bugs.webkit.org/attachment.cgi?id=255676&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.cpp:62
> + , m_kind(MediaSession::Kind::Default)</span >
Here in the MediaSession class, the name of this type is Kind, not MediaSession::Kind, so can leave off the MediaSession part.
Seems that m_kind could default to this in the header, then we could omit it in this constructor. Syntax we would normally use in the class definition is:
Kind m_kind { Kind::Default };
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:53
> + MediaSession(Document&);</span >
Probably should be:
explicit MediaSession(Document&);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>