[Webkit-unassigned] [Bug 146149] [GTK] Add initial WebKitWebsiteDataManager API for process configuration options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 04:43:51 PDT 2015


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 255402
  --> https://bugs.webkit.org/attachment.cgi?id=255402
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255402&action=review

Thanks for the review! Please, not that this depends on patch attached to bug #146145

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:156
>> +webkit_web_context_get_website_data_manager         (WebKitWebContext              *context);
> Shouln't we use const here because of the immutable thing?

Well, const in C is not exactly the same as in C++. The properties in WebKitWebsiteDataManager are construct-only, so the object can't be modified no matter if the pointer is const or not.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:158
>> +            priv->webSQLDirectory.reset(g_build_filename(priv->baseDataDirectory.get(), "databases", nullptr));
> Perhaps cache the value of "priv->baseDataDirectory.get()" in a local variable

What for? to make lines shorter?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/368f1c15/attachment.html>

More information about the webkit-unassigned mailing list