[Webkit-unassigned] [Bug 146149] [GTK] Add initial WebKitWebsiteDataManager API for process configuration options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 01:26:47 PDT 2015


Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #255402|review?                     |review+
              Flags|                            |

--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 255402
  --> https://bugs.webkit.org/attachment.cgi?id=255402
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255402&action=review

Provided we agree on the API this looks good to me

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:156
> +webkit_web_context_get_website_data_manager         (WebKitWebContext              *context);

Shouln't we use const here because of the immutable thing?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:158
> +            priv->webSQLDirectory.reset(g_build_filename(priv->baseDataDirectory.get(), "databases", nullptr));

Perhaps cache the value of "priv->baseDataDirectory.get()" in a local variable

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/8fbbdc4a/attachment.html>

More information about the webkit-unassigned mailing list