<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149">bug 146149</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255402&action=diff" name="attach_255402" title="Updated patch">attachment 255402</a> <a href="attachment.cgi?id=255402&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255402&action=review">https://bugs.webkit.org/attachment.cgi?id=255402&action=review</a>
Thanks for the review! Please, not that this depends on patch attached to <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Do not use legacy data store options in WebKit2 GTK+ API"
href="show_bug.cgi?id=146145">bug #146145</a>
<span class="quote">>> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:156
>> +webkit_web_context_get_website_data_manager (WebKitWebContext *context);
>
> Shouln't we use const here because of the immutable thing?</span >
Well, const in C is not exactly the same as in C++. The properties in WebKitWebsiteDataManager are construct-only, so the object can't be modified no matter if the pointer is const or not.
<span class="quote">>> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:158
>> + priv->webSQLDirectory.reset(g_build_filename(priv->baseDataDirectory.get(), "databases", nullptr));
>
> Perhaps cache the value of "priv->baseDataDirectory.get()" in a local variable</span >
What for? to make lines shorter?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>