<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149">bug 146149</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255402 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149">bug 146149</a>
from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255402&action=diff" name="attach_255402" title="Updated patch">attachment 255402</a> <a href="attachment.cgi?id=255402&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255402&action=review">https://bugs.webkit.org/attachment.cgi?id=255402&action=review</a>
Provided we agree on the API this looks good to me
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:156
> +webkit_web_context_get_website_data_manager (WebKitWebContext *context);</span >
Shouln't we use const here because of the immutable thing?
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:158
> + priv->webSQLDirectory.reset(g_build_filename(priv->baseDataDirectory.get(), "databases", nullptr));</span >
Perhaps cache the value of "priv->baseDataDirectory.get()" in a local variable</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>