[Webkit-unassigned] [Bug 145986] Media Session: Improve the safety of playback toggling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145986

--- Comment #7 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #6)
> Comment on attachment 254891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254891&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:97
> > +    ASSERT(!m_iteratedActiveParticipatingElements);
> 
> What guarantees this won’t happen? I’d think that if we make something play
> that some events might fire and in response we might run some code and end
> up back here.
> 
> Maybe we need to handle this case, perhaps by doing nothing?

This assertion is in the MediaSession::togglePlayback method which is currently only called in response to play/pause media keys. This method will never call itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150615/b8247bf9/attachment.html>